[Webkit-unassigned] [Bug 119618] Adding a .ycm_extra_conf file for webkitGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119618





--- Comment #6 from Martin Robinson <mrobinson at webkit.org>  2013-12-12 15:16:56 PST ---
(In reply to comment #3)
> I have just a couple of nits in this informal review. Apart from those, the
> script is great and YCM is a really welcome addition to Vim (I did not know
> about it before today :D)

Thanks for the review!


> > Tools/gtk/ycm_extra_conf.py:30
> > +sys.path = [__tools_directory] + sys.path
> 
> It would be good to use os.path.abspath() after determining
> __tools_directory, just in case.

Okay.


> > Tools/gtk/ycm_extra_conf.py:113
> > +def FlagsForFile(filename):
> 
> According to the YouCompleteMe documentation, FlagsForFile may be passed
> keyword arguments, so this should be:
> 
>   def FlagsForFile(filename, **kwargs)
> 
> Even if the keyword arguments are unused for the moment, it is good to
> include them in the function signature just in case users have set an
> option in their vimrc to send extra arguments to YCM.

Good idea. I'll make the change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.