[Webkit-unassigned] [Bug 125094] [Nix] Add other UIProcess files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125094


WebKit Commit Bot <commit-queue at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |commit-queue at webkit.org




--- Comment #2 from WebKit Commit Bot <commit-queue at webkit.org>  2013-12-12 12:11:12 PST ---
Attachment 219107 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/nix/TextCheckerNix.cpp', u'Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h', u'Source/WebKit2/UIProcess/nix/WebContextNix.cpp', u'Source/WebKit2/UIProcess/nix/WebInspectorProxyNix.cpp', u'Source/WebKit2/UIProcess/nix/WebPageProxyNix.cpp', u'Source/WebKit2/UIProcess/nix/WebPopupMenuListenerNix.cpp', u'Source/WebKit2/UIProcess/nix/WebPopupMenuListenerNix.h', u'Source/WebKit2/UIProcess/nix/WebProcessProxyNix.cpp', u'Source/WebKit2/UIProcess/nix/WebViewClientNix.cpp', u'Source/WebKit2/UIProcess/nix/WebViewClientNix.h', u'Source/WebKit2/UIProcess/nix/WebViewNix.cpp', u'Source/WebKit2/UIProcess/nix/WebViewNix.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.cpp:71:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.cpp:72:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/nix/WebPageProxyNix.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebPageProxyNix.cpp:33:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h:34:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h:39:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h:46:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h:47:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebContextMenuProxyNix.h:49:  Missing space inside { }.  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebViewClientNix.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewClientNix.cpp:49:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/nix/TextCheckerNix.cpp:132:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
ERROR: Source/WebKit2/UIProcess/nix/TextCheckerNix.cpp:132:  There was more than one newline at the end of the file.  [whitespace/ending_newline] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebViewClientNix.h:30:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewClientNix.h:32:  wtf includes should be <wtf/file.h> instead of "wtf/file.h".  [build/include] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewClientNix.h:50:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit2/UIProcess/nix/WebContextNix.cpp:29:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebContextNix.cpp:35:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:37:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:48:  The parameter name "viewClient" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:50:  The parameter name "point" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:93:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/nix/WebViewNix.h:93:  The parameter name "pageGroup" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 26 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.