[Webkit-unassigned] [Bug 125375] REGRESSION (r160152): Selection drag snapshot doesn't appear or has the wrong content on Retina

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 12 11:08:56 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=125375





--- Comment #19 from Timothy Hatcher <timothy at apple.com>  2013-12-12 11:07:07 PST ---
(In reply to comment #18)
> (In reply to comment #16)
> > > How did we test this code path? What kinds of tests fail when we pass 1 here instead of the device scale factor?
> > 
> > To my knowledge, all of the drag-related test cases in TestWebKitAPI are reftests and wouldn't be able to detect bad scaling behavior if all the snapshot methods do it incorrectly the same way. Are there any examples of deviceScaleFactor tests that check for similar regressions?
> 
> Sorry, I wasn’t referring to automated tests, although those would be great!

I was testing the various paths on my retina machine for Brian.

His latest patch (attachment 219087) fixes the selection and HTML5 dragging cases, but regresses <img> drag — the drag image is half size. We are looking into that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list