[Webkit-unassigned] [Bug 125600] Need ObjC APIs for some InjectedBundle classes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125600


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219020|review?                     |review-
               Flag|                            |




--- Comment #5 from Sam Weinig <sam at webkit.org>  2013-12-12 10:53:46 PST ---
(From update of attachment 219020)
View in context: https://bugs.webkit.org/attachment.cgi?id=219020&action=review

>> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:41
>> +- (JSGlobalContextRef)jsContextForWorld:(WKWebProcessPlugInScriptWorld *)world;
> 
> I believe that we should avoid the C JavaScript API types in our Cocoa API, so this method should return a (JSContext *).

Yeah, this should use the Objective-C JS API.

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:42
> +- (WKWebProcessPlugInHitTestResult *)hitTest:(CGPoint)point;

Can we put HitTest on the browsing controller instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.