[Webkit-unassigned] [Bug 119618] Adding a .ycm_extra_conf file for webkitGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119618


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219016|review?                     |review+
               Flag|                            |




--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2013-12-12 10:40:10 PST ---
(From update of attachment 219016)
View in context: https://bugs.webkit.org/attachment.cgi?id=219016&action=review

LGTM, with a small refactoring proposal for the first function

> Tools/gtk/ycm_extra_conf.py:47
> +            for flag in FLAGS_PRECEDING_PATHS:

This for block could be replaced by if argument in FLAGS_PRECEDING_PATHS, you could always ensure argument is either a flag or a path to have a single code path here, it will be much more readable.

> Tools/gtk/ycm_extra_conf.py:54
> +                # Some argument contain the flag and the path together. For these

Missing last bit of the comment?

> Tools/gtk/ycm_extra_conf.py:101
> +        print "==== Error during reading %s file", trace_file_path

s/during/while/?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.