[Webkit-unassigned] [Bug 125637] Broken error recovery in @media at-rule

Thu Dec 12 07:45:14 PST 2013

https://bugs.webkit.org/show_bug.cgi?id=125637

--- Comment #7 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-12-12 07:43:25 PST ---
(From update of attachment 219081)
View in context: https://bugs.webkit.org/attachment.cgi?id=219081&action=review

> LayoutTests/ChangeLog:1
> +2013-12-12  Martin Hodovan  <mhodovan at webkit.org>

This email address conflicts with the other ChangeLog's email address. Which one is the correct one?

> LayoutTests/fast/css/media-error-recovery.html:18
> +	if (window.testRunner)
> +    	testRunner.dumpAsText();
> +</script>
> +
> +<style>
> +	@media {
> +		body { background-color: green; }
> +		.foo background-color: red; }
> +	}
> +</style>		
> +</head>
> +<body>
> +	Background should be green.
> +</body>

I'm not an expert in LayoutTests but this looks as it will always dump the text: 'Background should be green.' which is not good. You won't be able to detect the difference with the test scripts (run-webkit-tests). A better way would be adding js script which checks the color of the background after it is loaded.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.