[Webkit-unassigned] [Bug 125006] [curl] Improve detecting and handling of SSL client certificate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125006





--- Comment #5 from sipka at inf.u-szeged.hu  2013-12-12 02:45:00 PST ---
Thanks for the reply!

(In reply to comment #3)
> (From update of attachment 218867 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218867&action=review
> 
> > Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:129
> > +        addAllowedClientCertificate(host.lower(), certificate, key);
> 
> We should move the .lower() call into the addAllowedClientCertificate method.
> 
> > Source/WebCore/platform/network/curl/SSLHandle.cpp:60
> > +    HashMap<String, clientCertificate>::iterator it = allowedClientHosts.find(host);
> 
> Shouldn't the host be in lowercase? When you add items into the allowedClientHosts the host is in lowercase (see setClientCertificateInfo method).

Yes, these modifications ensure the expected behavior. I fixed these in the newest patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.