[Webkit-unassigned] [Bug 125595] Web Inspector: Add Inspector Code Generation to JavaScriptCore for Runtime Domain

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125595


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219026|                            |review?, commit-queue-
               Flag|                            |




--- Comment #1 from Joseph Pecoraro <joepeck at webkit.org>  2013-12-11 18:13:53 PST ---
Created an attachment (id=219026)
 --> (https://bugs.webkit.org/attachment.cgi?id=219026&action=review)
[PATCH] Proposed Fix

Sorry, I don't think I can easily break this up into pieces.

High level comment on how files are changing:

JavaScriptCore gains:

    JavaScriptCore/inspector/prototype/Runtime.json
    JavaScriptCore/scripts/CodeGeneratorInspector.py (exported to PrivateHeaders so WebCore can use it)
    JavaScriptCore/scripts/CodeGeneratorInspectorStrings.py (exported to PrivateHeaders so WebCore can use it)
    JavaScriptCore/scripts/generate-combined-inspector-json.py (exported to PrivateHeaders so WebCore can use it)

    DerivedSources/InspectorJS.json (exported to PrivateHeaders so WebCore can use it)
    DerivedSources/InspectorJSBackendCommands.js
    DerivedSources/InspectorJSBackendDispatchers.{h,cpp} (exported to PrivateHeaders so WebCore can use it)
    DerivedSources/InspectorJSFrontendDispatchers.{h,cpp} (exported to PrivateHeaders so WebCore can use it)
    DerivedSources/InspectorJSTypeBuilders.{h,cpp} (exported to PrivateHeaders so WebCore can use it)

WebCore's Derived Sources change name:

    DerivedSources/InspectorWeb.json
    DerivedSources/InspectorWebBackendCommands.js
    DerivedSources/InspectorWebBackendDispatchers.{h,cpp}
    DerivedSources/InspectorWebFrontendDispatchers.{h,cpp}
    DerivedSources/InspectorWebTypeBuilders.{h,cpp}

WebInspectorUI and LayoutTests:

    Now we have to worry about loading both a InspectorJSBackendCommands.js
    and InspectorWebBackendCommands.js where appropriate.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.