[Webkit-unassigned] [Bug 125248] Missing ENABLE(DRAG_SUPPORT) guards for drag-specific DragImage functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125248


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #218932|review?                     |review+
               Flag|                            |




--- Comment #8 from Darin Adler <darin at apple.com>  2013-12-11 14:36:00 PST ---
(From update of attachment 218932)
View in context: https://bugs.webkit.org/attachment.cgi?id=218932&action=review

Change seems OK, but also seems that for platforms where DRAG_SUPPORT isn’t supported, we should leave out the functions for that entirely instead of having (#if DRAG_SUPPORT, return 0, #endif) placeholders that don’t do anything useful.

> Source/WebCore/platform/DragImage.h:66
>  // These functions should be memory neutral, eg. if they return a newly allocated image,
>  // they should release the input image. As a corollary these methods don't guarantee
>  // the input image ref will still be valid after they have been called.

This comment is only about the three functions that both take and return a DragImageRef, all of which are inside the #if. I think it’s peculiar to have it up here where it seems to apply to many other functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.