[Webkit-unassigned] [Bug 125006] [curl] Improve detecting and handling of SSL client certificate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 11 11:26:19 PST 2013


--- Comment #3 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-12-11 11:24:31 PST ---
(From update of attachment 218867)
View in context: https://bugs.webkit.org/attachment.cgi?id=218867&action=review

> Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:129
> +        addAllowedClientCertificate(host.lower(), certificate, key);

We should move the .lower() call into the addAllowedClientCertificate method.

> Source/WebCore/platform/network/curl/SSLHandle.cpp:60
> +    HashMap<String, clientCertificate>::iterator it = allowedClientHosts.find(host);

Shouldn't the host be in lowercase? When you add items into the allowedClientHosts the host is in lowercase (see setClientCertificateInfo method).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list