[Webkit-unassigned] [Bug 122868] Web Inspector: ES6: JavaScript syntax highlighting and recognition of for..of

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122868


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #218969|review?                     |review-
               Flag|                            |




--- Comment #12 from Timothy Hatcher <timothy at apple.com>  2013-12-11 10:16:33 PST ---
(From update of attachment 218969)
View in context: https://bugs.webkit.org/attachment.cgi?id=218969&action=review

> Source/WebInspectorUI/UserInterface/External/CodeMirror/codemirror.js:5570
> -      var result = /\-[^ \-?]|\?[^ !\'\"\),.\-\/:;\?\]\}]/.test(str.slice(i - 1, i + 1));
> -      return result;
> +      return /\-[^ \-?]|\?[^ !\'\"\),.\-\/:;\?\]\}]/.test(str.slice(i - 1, i + 1));

Sorry for the confusion. My comment wasn't meant for the PrettyPrinting copy. It was meant for the main codemirror.js. The version in UserInterface is the one we use jsmin.js on, but both copies in our tree should be the same.

> Source/WebInspectorUI/UserInterface/External/CodeMirror/codemirror.js:5583
> -      var result = /[~!#%&*)=+}\]|\"\.>,:;][({[<]|-[^\-?\.\u2010-\u201f\u2026]|\?[\w~`@#$%\^&*(_=+{[|><]|…[\w~`@#$%\^&*(_=+{[><]/.test(str.slice(i - 1, i + 1));
> -      return result;
> +      return /[~!#%&*)=+}\]\\|\"\.>,:;][({[<]|-[^\-?\.\u2010-\u201f\u2026]|\?[\w~`@#$%\^&*(_=+{[|><]|…[\w~`@#$%\^&*(_=+{[><]/.test(str.slice(i - 1, i + 1));

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.