[Webkit-unassigned] [Bug 125536] [CSS Shapes] Simplify RectangleShape implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 10 15:30:52 PST 2013


--- Comment #2 from Hans Muller <giles_joplin at yahoo.com>  2013-12-10 15:29:05 PST ---
Created an attachment (id=218914)
 --> (https://bugs.webkit.org/attachment.cgi?id=218914&action=review)

Instead of caching an instance of a private FloatRoundedRect (ish) class for RectangleShape's shape-margin and shape-padding bounds, we just compute the FloatRect and radii as needed. This reduces the classes footprint a little and it simplifies the implementation.

Removed the private RectangleShape::ShapeBounds class and made its cornerInterceptForWidth() method a static function. Added members for the RectangleShape constructor args, and private getters for their properties. There are no new tests because this is just an internal refactoring.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list