[Webkit-unassigned] [Bug 125366] Add missing ENABLE(DRAG_SUPPORT) guards for DragData and its clients

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 9 10:43:38 PST 2013


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |darin at apple.com

--- Comment #7 from Darin Adler <darin at apple.com>  2013-12-09 10:41:53 PST ---
(In reply to comment #5)
> BTW, are there guidelines for when to add guards to forward declarations of classes? I've seen some of the larger files like Frame, Page, and WebPage do that, but not many other files. Is this coming into vogue, going out of style, or just not widely applied?

We don’t have a consistent rule. I think I prefer not to guard forward declarations at all. The benefits of additional compile time errors don’t seem to outweigh the inelegance of the additional conditionals.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list