[Webkit-unassigned] [Bug 125446] Store SHA1 hash in std::array.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 9 10:32:32 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=125446





--- Comment #2 from Anders Carlsson <andersca at apple.com>  2013-12-09 10:30:46 PST ---
(From update of attachment 218752)
View in context: https://bugs.webkit.org/attachment.cgi?id=218752&action=review

> Source/WTF/wtf/SHA1.h:61
> +    // Size of the SHA1 hash
> +    WTF_EXPORT_PRIVATE static const size_t hashSize = 20;

how about we add

typedef std::array<uint8_t, hashSize> Digest;

here - then we don’t have to use hashSize everywhere. Patch looks good otherwise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list