[Webkit-unassigned] [Bug 124848] Add support for multiple sources for AutoInstaller

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 9 10:09:36 PST 2013


--- Comment #3 from Berta József <jberta.u-szeged at partner.samsung.com>  2013-12-09 10:07:47 PST ---
(From update of attachment 217818)
View in context: https://bugs.webkit.org/attachment.cgi?id=217818&action=review

>> Tools/Scripts/webkitpy/common/system/autoinstall.py:51
>> +_mirror_regexs = re.compile('.*sourceforge.*'), re.compile('.*pypi.*')
> Why don't we have a single array that contains both the regular expression and the env. variable name instead of zip'ing in _prepare_mirrors?

I just think it's clearer to have these separated here, and put them together after the env. variables are processed. It might reduce readability if the array would be made here with the variable names, and later replaced by the contents.

>> Tools/Scripts/webkitpy/common/system/autoinstall.py:359
>> +                        continue
> It's strange that we'll select the next mirror only if the current mirror matched.
> How does that work?

The url will match sourceforge or pypi, if the original url did, and if the mirrors are from the mirror sources above. So I decided to distinguish the source by the url. If the current url doesn't matched, it's not from pypi or sourceforge.
The other way could be to add an indicator to each source in the webkitpy/thirdparty/__init__.py, but it's not necessary in this case.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list