[Webkit-unassigned] [Bug 125424] check-webkit-style should check for extra newlines at EOF

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 9 00:28:02 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=125424





--- Comment #4 from László Langó <lango at inf.u-szeged.hu>  2013-12-09 00:26:17 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > This will log both errors when there is no new line at the and but there is a blank line before it. This is confusing.
> 
> I'm not sure what test case you are describing. Can you give a concrete example?

example:
//firstline \n
//secondline \n
\n
//last line

This will log both errors, because there is no new line at the end, but there is a blank line before it.

> (It's entirely possible that this extra-newlines-at-EOL check should just be merged with the missing-EOF-newline check)
I think the merge is a good idea.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list