[Webkit-unassigned] [Bug 125417] [GTK] Do not skip attributes with only custom setter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125417


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #218696|review?                     |review+
               Flag|                            |




--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2013-12-08 10:05:20 PST ---
(From update of attachment 218696)
View in context: https://bugs.webkit.org/attachment.cgi?id=218696&action=review

> Source/WebCore/ChangeLog:9
> +        * bindings/gobject/GNUmakefile.am: Generate
> +        WebKitDOMMediaController that is now required by an attribute

This could be a longer line =P

> Source/WebCore/ChangeLog:11
> +        * bindings/gobject/WebKitDOMCustom.cpp: Remove mothods that are now generated.

*mothods

> Source/WebCore/ChangeLog:16
> +        (SkipAttribute): Do not skip attributes having a custom setter.

Can you change the description to say we will now generate getters for properties that have custom setters? I was confused for a while.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.