[Webkit-unassigned] [Bug 78883] [GStreamer] AudioSourceProvider support in the MediaPlayer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78883





--- Comment #42 from Gustavo Noronha (kov) <gns at gnome.org>  2013-12-07 02:21:06 PST ---
(From update of attachment 218586)
View in context: https://bugs.webkit.org/attachment.cgi?id=218586&action=review

> Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:163
> +    // Check the first audio channel. The buffer is supposed to store
> +    // data of a single channel anyway.

I got confused a bit with this comment, are you saying that the buffer will always have only 1 channel represented, so we just need to check the first?

> Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:287
> +    // TODO: Don't use a capsfilter in front of deinterleave,

s/TODO/FIXME/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.