[Webkit-unassigned] [Bug 125369] Fix build for PLATFORM(MAC) && !ENABLE(DRAG_SUPPORT)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125369





--- Comment #6 from Brian Burg <burg at cs.washington.edu>  2013-12-07 00:17:10 PST ---
Thanks for the quick turnaround.

(In reply to comment #5)
> (From update of attachment 218643 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218643&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Build fix for PLATFORM(MAC) && !ENABLE(DRAG_SUPPORT)
> 
> I don’t think this is helpful to do. We don’t need to support all combinations of ENABLE and PLATFORM. We do want to build for iOS without drag supported, but I see no reason we have to support non-iOS PLATFORM(MAC) with drag support off.

I really just want the ENABLE(DRAG_SUPPORT) guards to be accurate in DragImage.h. However, changing DragImage.{cpp,h} first will cascade into also fixing DragData, DragClient, and other stuff, so I wanted to split up the patches. This first patch was just getting me to a baseline where I can test !ENABLE(DRAG_SUPPORT) from a non-windows environment. The other patches fix guards for DragData, DragClient, and DragImage mostly independently.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.