[Webkit-unassigned] [Bug 125369] Fix build for PLATFORM(MAC) && !ENABLE(DRAG_SUPPORT)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125369


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #218643|review?                     |review-
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2013-12-06 20:01:59 PST ---
(From update of attachment 218643)
View in context: https://bugs.webkit.org/attachment.cgi?id=218643&action=review

> Source/WebCore/ChangeLog:3
> +        Build fix for PLATFORM(MAC) && !ENABLE(DRAG_SUPPORT)

I don’t think this is helpful to do. We don’t need to support all combinations of ENABLE and PLATFORM. We do want to build for iOS without drag supported, but I see no reason we have to support non-iOS PLATFORM(MAC) with drag support off.

> Source/WebCore/dom/ClipboardMac.mm:29
> +#if ENABLE(DRAG_SUPPORT)

Not helpful to add this.

> Source/WebCore/platform/DragImage.cpp:-29
> -#if ENABLE(DRAG_SUPPORT)

Fine to remove this.

> Source/WebCore/platform/mac/DragImageMac.mm:-29
> -#if ENABLE(DRAG_SUPPORT)

Fine to remove this.

> Source/WebCore/platform/mac/PasteboardMac.mm:144
> +#if ENABLE(DRAG_SUPPORT)

Not helpful to add this.

> Source/WebCore/platform/mac/PasteboardMac.mm:645
> +#if ENABLE(DRAG_SUPPORT)

Not helpful to add this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.