[Webkit-unassigned] [Bug 125324] Web Inspector: Push More Inspector Required Classes Down into JavaScriptCore

Fri Dec 6 16:47:27 PST 2013

https://bugs.webkit.org/show_bug.cgi?id=125324

--- Comment #13 from WebKit Commit Bot <commit-queue at webkit.org>  2013-12-06 16:45:43 PST ---
Attachment 218632 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/InspectorAgentBase.h', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.cpp', u'Source/JavaScriptCore/inspector/InspectorAgentRegistry.h', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp', u'Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h', u'Source/JavaScriptCore/inspector/InspectorValues.cpp', u'Source/JavaScriptCore/inspector/InspectorValues.h', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentBase.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorAgentRegistry.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/ForwardingHeaders/inspector/InspectorValues.h', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/ScriptProfile.cpp', u'Source/WebCore/bindings/js/ScriptProfile.h', u'Source/WebCore/bindings/js/ScriptValue.cpp', u'Source/WebCore/bindings/js/ScriptValue.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/CodeGeneratorInspector.py', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/ConsoleMessage.cpp', u'Source/WebCore/inspector/ConsoleMessage.h', u'Source/WebCore/inspector/ContentSearchUtils.cpp', u'Source/WebCore/inspector/ContentSearchUtils.h', u'Source/WebCore/inspector/InjectedScript.cpp', u'Source/WebCore/inspector/InjectedScriptBase.cpp', u'Source/WebCore/inspector/InjectedScriptBase.h', u'Source/WebCore/inspector/InjectedScriptCanvasModule.cpp', u'Source/WebCore/inspector/InjectedScriptHost.cpp', u'Source/WebCore/inspector/InjectedScriptHost.h', u'Source/WebCore/inspector/InjectedScriptManager.cpp', u'Source/WebCore/inspector/InjectedScriptManager.h', u'Source/WebCore/inspector/InjectedScriptModule.cpp', u'Source/WebCore/inspector/InspectorAgent.cpp', u'Source/WebCore/inspector/InspectorAgent.h', u'Source/WebCore/inspector/InspectorAgentRegistry.cpp', u'Source/WebCore/inspector/InspectorAgentRegistry.h', u'Source/WebCore/inspector/InspectorAllInOne.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp', u'Source/WebCore/inspector/InspectorApplicationCacheAgent.h', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorBackendDispatcher.h', u'Source/WebCore/inspector/InspectorBaseAgent.h', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.h', u'Source/WebCore/inspector/InspectorCanvasAgent.cpp', u'Source/WebCore/inspector/InspectorCanvasAgent.h', u'Source/WebCore/inspector/InspectorClient.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorConsoleAgent.cpp', u'Source/WebCore/inspector/InspectorConsoleAgent.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.h', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDOMDebuggerAgent.h', u'Source/WebCore/inspector/InspectorDOMStorageAgent.cpp', u'Source/WebCore/inspector/InspectorDOMStorageAgent.h', u'Source/WebCore/inspector/InspectorDatabaseAgent.cpp', u'Source/WebCore/inspector/InspectorDatabaseAgent.h', u'Source/WebCore/inspector/InspectorDatabaseResource.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendClientLocal.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorHeapProfilerAgent.h', u'Source/WebCore/inspector/InspectorIndexedDBAgent.cpp', u'Source/WebCore/inspector/InspectorIndexedDBAgent.h', u'Source/WebCore/inspector/InspectorInputAgent.cpp', u'Source/WebCore/inspector/InspectorInputAgent.h', u'Source/WebCore/inspector/InspectorInstrumentation.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorLayerTreeAgent.h', u'Source/WebCore/inspector/InspectorMemoryAgent.cpp', u'Source/WebCore/inspector/InspectorMemoryAgent.h', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorOverlay.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/InspectorPageAgent.h', u'Source/WebCore/inspector/InspectorProfilerAgent.cpp', u'Source/WebCore/inspector/InspectorProfilerAgent.h', u'Source/WebCore/inspector/InspectorResourceAgent.cpp', u'Source/WebCore/inspector/InspectorResourceAgent.h', u'Source/WebCore/inspector/InspectorRuntimeAgent.cpp', u'Source/WebCore/inspector/InspectorRuntimeAgent.h', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.h', u'Source/WebCore/inspector/InspectorStyleTextEditor.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.cpp', u'Source/WebCore/inspector/InspectorTimelineAgent.h', u'Source/WebCore/inspector/InspectorValues.cpp', u'Source/WebCore/inspector/InspectorValues.h', u'Source/WebCore/inspector/InspectorWebAgentBase.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/InspectorWorkerAgent.h', u'Source/WebCore/inspector/InstrumentingAgents.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/PageConsoleAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.cpp', u'Source/WebCore/inspector/PageDebuggerAgent.h', u'Source/WebCore/inspector/PageRuntimeAgent.cpp', u'Source/WebCore/inspector/PageRuntimeAgent.h', u'Source/WebCore/inspector/ScriptArguments.cpp', u'Source/WebCore/inspector/ScriptCallFrame.cpp', u'Source/WebCore/inspector/ScriptCallFrame.h', u'Source/WebCore/inspector/ScriptCallStack.cpp', u'Source/WebCore/inspector/ScriptCallStack.h', u'Source/WebCore/inspector/TimelineRecordFactory.cpp', u'Source/WebCore/inspector/TimelineRecordFactory.h', u'Source/WebCore/inspector/WorkerConsoleAgent.cpp', u'Source/WebCore/inspector/WorkerDebuggerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/inspector/WorkerInspectorController.h', u'Source/WebCore/inspector/WorkerRuntimeAgent.cpp', u'Source/WebCore/inspector/WorkerRuntimeAgent.h', u'Source/WebCore/page/ContentSecurityPolicy.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebInspector.h', '--commit-queue']" exit_code: 1
ERROR: Source/WebCore/inspector/CodeGeneratorInspector.py:265:  [RawTypes.BaseType.get_raw_validator_call_text] Class 'BaseType' has no 'get_validate_method_params' member  [pylint/E1101] [5]
ERROR: Source/WebCore/inspector/InspectorLayerTreeAgent.cpp:54:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorCSSAgent.cpp:620:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorRuntimeAgent.cpp:63:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:45:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:46:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:47:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:48:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:49:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:50:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:51:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:52:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:53:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:54:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:55:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:56:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:92:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:388:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:426:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:429:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:472:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:473:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:510:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:611:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:615:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:701:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.cpp:709:  Local variables should never be PassRefPtr (see http://webkit.org/coding/RefPtr.html).  [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorTimelineAgent.cpp:585:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:43:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorBackendDispatcher.h:97:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:50:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:73:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:87:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:110:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:111:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:112:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:130:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/inspector/InspectorValues.h:131:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:561:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorWorkerAgent.cpp:112:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp:50:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorStyleSheet.h:66:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorCanvasAgent.cpp:67:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorMemoryAgent.cpp:90:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorHeapProfilerAgent.cpp:54:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorDebuggerAgent.cpp:60:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorPageAgent.cpp:356:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorDOMAgent.cpp:215:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorConsoleAgent.cpp:64:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorProfilerAgent.cpp:124:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorResourceAgent.cpp:654:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorDatabaseAgent.cpp:214:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorAgent.cpp:63:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp:74:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorInputAgent.cpp:57:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:60:  Comma should be at the beginning of the line in a member initialization list.  [whitespace/init] [4]
Total errors found: 56 in 123 files

If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.