[Webkit-unassigned] [Bug 100275] Programmatically-inserted children lack accessibility events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100275





--- Comment #14 from chris fleizach <cfleizach at apple.com>  2013-12-06 08:06:20 PST ---
(From update of attachment 218589)
View in context: https://bugs.webkit.org/attachment.cgi?id=218589&action=review

looks pretty much ok, just a few minor things

> Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:45
> +        bomb->updateBackingStore();

i assume you don't want to add this

> Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:89
> +    size_t index = coreParent->children().find(obj);

you should probably check that index != WTF::notFOund before proceeding and possible assert that condition

> Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:199
> +        for (int i = 0; i < atk_object_get_n_accessible_children(axObject); ++i)

this should be in a var so we don't query each iteration through the run loop
atk_object_get_n_accessible_children(axObject)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.