[Webkit-unassigned] [Bug 100275] Programmatically-inserted children lack accessibility events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100275





--- Comment #12 from Mario Sanchez Prada <mario at webkit.org>  2013-12-06 02:40:27 PST ---
(In reply to comment #11)
> (From update of attachment 218292 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218292&action=review
> 
> > LayoutTests/accessibility/children-changed-sends-notification.html:16
> > +description("This test sure that a notification is being emitted when children are added or removed for an accessibility object");
> 
> sure -> ensures

Ok.

> > Source/WebCore/accessibility/AXObjectCache.h:233
> > +    bool m_destructionInProgress;
> 
> instead of a global AXObjectCache flag, maybe we should have a parameter for 
> detach() that informs us which kind of detach it is. DocumentDestroyed, 
> ElementDestroyed (are there others?)
> 
Ok. That was actually my first approach to the problem, but in the end I did this just to keep the patch smaller.

But I can change it back anyway. Thanks for the suggestion.

> > Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:41
> > +    AtkObject* wrapper = obj->wrapper();
> 
> you might want to ASSERT(wrapper) here
> 
Makes sense.

> > Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:51
> > +            // since the accessibility hierarchy in WebCore won't be longer navigable now.
> 
> 'in WebCore will no longer be navigable'
> 
Ok

> > Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:195
> > +            GRefPtr<AtkObject> child(atk_object_ref_accessible_child(axObject, i));
> 
> Does this make a AtkObject with the WebCore object?
> If so, where does it get cached?

This call creates and uses the childrenVector of WebCore objects from the object wrapped by axObject to create and return a child AtkObject wrapping an already existing WebCore object.

So, the returned AtkObject will always wrap a WebCore object that has been previously added to the AXObjectCache.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.