[Webkit-unassigned] [Bug 125298] 32bit buildfix after r160151

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 5 14:41:41 PST 2013


Csaba Osztrogonác <ossy at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #218503|                            |review+, commit-queue+
               Flag|                            |

--- Comment #6 from Csaba Osztrogonác <ossy at webkit.org>  2013-12-05 14:39:59 PST ---
(From update of attachment 218503)
View in context: https://bugs.webkit.org/attachment.cgi?id=218503&action=review

>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943
>> +    GST_LOG_OBJECT(src, "Have %lld bytes of data", priv->buffer ? static_cast<long long>(gst_buffer_get_size(priv->buffer.get())) : length);
> Perhaps use %zd ?

gst_buffer_get_size returns unsigned int (32bit), length is int (32bit).
An unsigned int can be extended properly to long long int (64bit) on x86.
So it is the proper fix, r=me to fix the build as soon as possible.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list