[Webkit-unassigned] [Bug 125278] Save original text for RenderText to a map

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125278


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #218529|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2013-12-05 12:32:22 PST ---
(From update of attachment 218529)
View in context: https://bugs.webkit.org/attachment.cgi?id=218529&action=review

Gotta fix the NDEBUG problem. Otherwise looks good to me, and I can’t spot any bugs. Not sure we have sufficient test coverage.

> Source/WebCore/rendering/RenderText.cpp:100
> +typedef HashMap<const RenderText*, String> OriginalTextMap;

Not sure we benefit from using a typedef for this since the type is only used twice. Also extra blank line before this typedef.

> Source/WebCore/rendering/RenderText.cpp:204
>  RenderText::~RenderText()
>  {
> +    if (m_originalTextDiffersFromRendered)
> +        originalTextMap().remove(this);
>  }

We need to take this out of #ifndef NDEBUG since we are going to use it for non-debugging purposes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.