[Webkit-unassigned] [Bug 125228] Use ThreadingOnce class to encapsulate pthread_once functionality.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125228





--- Comment #8 from peavo at outlook.com  2013-12-05 07:45:19 PST ---
(In reply to comment #5)
> This is wrong. Please roll it out.
> 
> It is incorrect for WTF::ThreadingOnce to be declared static. Since we build without thread-safe statics, that declaration is not thread-safe.
> 
> Also, if statics were thread-safe, there would be no need for WTF::ThreadingOnce to contain any logic or data members: the constructor could just call the provided function, and you could rely on the compiler to ensure that the constructor was called only once.
> 
> Therefore, this patch is either meaningless or wrong, depending on your platform.

Thanks for catching this.
A couple of other places needs to be changed as well, I've made bug 125305 for this.
Sorry for the inconvienience.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.