[Webkit-unassigned] [Bug 125168] [MIPS] Wrong register usage in LLInt op_catch.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125168





--- Comment #3 from Balazs Kilvady <kilvadyb at homejinni.com>  2013-12-03 11:12:31 PST ---
(In reply to comment #2)
> (From update of attachment 218311 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218311&action=review
> 
> > Source/JavaScriptCore/offlineasm/mips.rb:-535
> > -            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name)
> > +            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name) || /_llint_op_catch/.match(node.name)
> >                  # Functions called from trampoline/JIT codes.
> >                  myList << Instruction.new(node.codeOrigin, "pichdr", [])
> > -            elsif /_llint_op_catch/.match(node.name)
> > -                # Exception cactcher entry point function.
> > -                myList << Instruction.new(node.codeOrigin, "pichdrra", [])
> 
> This is atrocious.  Are you seriously matching label names?

Yes. On MIPS for PIC compatibility a special header (pichdr) needed. I didn't find a better way to add PIC header only to the "entry point" functions/ops.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.