[Webkit-unassigned] [Bug 125168] [MIPS] Wrong register usage in LLInt op_catch.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125168


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #218311|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Filip Pizlo <fpizlo at apple.com>  2013-12-03 11:04:50 PST ---
(From update of attachment 218311)
View in context: https://bugs.webkit.org/attachment.cgi?id=218311&action=review

> Source/JavaScriptCore/offlineasm/mips.rb:-535
> -            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name)
> +            if /_prologue$/.match(node.name) || /^_llint_function_/.match(node.name) || /_llint_op_catch/.match(node.name)
>                  # Functions called from trampoline/JIT codes.
>                  myList << Instruction.new(node.codeOrigin, "pichdr", [])
> -            elsif /_llint_op_catch/.match(node.name)
> -                # Exception cactcher entry point function.
> -                myList << Instruction.new(node.codeOrigin, "pichdrra", [])

This is atrocious.  Are you seriously matching label names?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.