[Webkit-unassigned] [Bug 124147] Report error when #else is used in message receiver generator's input.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 3 03:14:01 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=124147
--- Comment #8 from Gergő Balogh <geryxyz at inf.u-szeged.hu> 2013-12-03 03:12:22 PST ---
(In reply to comment #6)
> (From update of attachment 217986 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217986&action=review
>
> This change is good, please feel free to review and land as appropriate.
Could you please set r+ and c+ for it as a WebKit2 owner?
>
> > Source/WebKit2/Scripts/webkit2/messages_unittest.py:1130
> > + with self.assertRaisesRegexp(Exception, r"ERROR: '#else.*' are not supported in the \*\.in files"):
>
> Where does this ".*" come from? How is it helpful?
>
> > Source/WebKit2/Scripts/webkit2/parser.py:68
> > + raise Exception("ERROR: '%s' are not supported in the *.in files" % trimmed)
>
> Shouldn't it be "... is not supported in .in files" (no "the", and singular)?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list