[Webkit-unassigned] [Bug 122125] Web Inspector: restore navigation panel state across page reloads and reopens

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 2 17:33:01 PST 2013


--- Comment #5 from Brian Burg <burg at cs.washington.edu>  2013-12-02 17:31:22 PST ---
(From update of attachment 218123)
View in context: https://bugs.webkit.org/attachment.cgi?id=218123&action=review

>> Source/WebInspectorUI/UserInterface/Main.js:723
>> +WebInspector._provisionalLoadCommitted = function(event)
> Where is the addEventListener call for this? Also, IIRC, some navigations do not fire ProvisionalLoadCommitted and only fire MainResourceDidChange. I think about:blank or data URLs are like that.

Oops, the addEventListener got lost in the rebase somehow.

For navigations without ProvisionalLoadCommitted, is there another event we can use as a time to save the view state? We can't use MainResourceDidChange, as some of the state is torn down by the time that event's handlers have all run.

>> Source/WebInspectorUI/UserInterface/NavigationSidebarPanel.js:171
>> +        this._allContentTreeOutlines.add(contentTreeOutline);
> contentTreeOutline is hidden by default when it is created. If the set is only suppose to contain the visible tree outlines, then this should only add to the set when dontHideByDefault is true.

Oh, I missed that. I will rename the set and add a conditional around this statement.

With this change, are there other places where I should be adding or removing tree outlines from the set of visible outlines?

>> Source/WebInspectorUI/UserInterface/NavigationSidebarPanel.js:193
>> +        // FIXME: this does not handle selections in the search results tree outline, or folder selections.
> But I think it would get the search result tree outline if it is the contentTreeOutline.

This comment is from a prior approach, I'll rewrite it to mention folder selections only.

>> Source/WebInspectorUI/UserInterface/NavigationSidebarPanel.js:553
>> +        return this._checkElementsForPendingViewStateCookie(workList);
> I'm not sure what this comment means.

Oh, the work list included the tree outlines as well as elements. I'll change this to prune the tree outlines (which should all be at the front, thus easy to remove).

>> Source/WebInspectorUI/UserInterface/NavigationSidebarPanel.js:580
>> +            });
> Object.shallowEqual?

This is asymmetric on purpose, because the saved cookie may contain other things (such as selected sidebar) besides the representedObject's serialized identity.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list