[Webkit-unassigned] [Bug 125048] Web Inspector: Use JSHint to check Inspector JS for code style problems

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125048





--- Comment #3 from Brian Burg <burg at cs.washington.edu>  2013-12-02 14:30:29 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > Before taking on this bug, I'll note that JSHint retains portions of JSLint's unpleasant Crockford license. (http://en.wikipedia.org/wiki/JSLint#License) So, it would be good to know if this 3rd-party library cannot be included in the project repository on those grounds.
> > 
> > I am not aware of any other reasonable 3rd-party JS style checkers. Closure Linter is unconfigurable and only enforces Google style.
> 
> We have jsmin.py with the Crockford license. But we need to get approval internally at Apple to add any third-party project to WebKit.

Ok, good to know, please update the bug if/when you get approval. I'll peck at the implementation more when I need a side-project break.

Of the steps mentioned, I have a patch for (0), and (4) already landed. I also landed a native readFile() so JSHint can run in "Rhino" mode.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.