[Webkit-unassigned] [Bug 122868] Web Inspector: ES6: JavaScript syntax highlighting and recognition of for..of

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122868


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #218053|review?                     |review-
               Flag|                            |




--- Comment #8 from Timothy Hatcher <timothy at apple.com>  2013-12-02 13:07:08 PST ---
(From update of attachment 218053)
View in context: https://bugs.webkit.org/attachment.cgi?id=218053&action=review

> Source/WebInspectorUI/Tools/PrettyPrinting/codemirror.js:5570
> -      var result = /\-[^ \-?]|\?[^ !\'\"\),.\-\/:;\?\]\}]/.test(str.slice(i - 1, i + 1));
> -      return result;
> +      return /\-[^ \-?]|\?[^ !\'\"\),.\-\/:;\?\]\}]/.test(str.slice(i - 1, i + 1));

This change breaks the jsmin.py script. It needs reverted. This is a local change to CodeMirror we have until we fix it. Testing copy-user-interface-resources.sh with COMBINE_INSPECTOR_RESOURCES = YES will show what I mean.

> Source/WebInspectorUI/Tools/PrettyPrinting/codemirror.js:5583
> -      var result = /[~!#%&*)=+}\]|\"\.>,:;][({[<]|-[^\-?\.\u2010-\u201f\u2026]|\?[\w~`@#$%\^&*(_=+{[|><]|…[\w~`@#$%\^&*(_=+{[><]/.test(str.slice(i - 1, i + 1));
> -      return result;
> +      return /[~!#%&*)=+}\]\\|\"\.>,:;][({[<]|-[^\-?\.\u2010-\u201f\u2026]|\?[\w~`@#$%\^&*(_=+{[|><]|…[\w~`@#$%\^&*(_=+{[><]/.test(str.slice(i - 1, i + 1));

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.