[Webkit-unassigned] [Bug 125064] Fix EFL build with INSPECTOR disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125064





--- Comment #3 from Peter Molnar <pmolnar.u-szeged at partner.samsung.com>  2013-12-02 02:43:16 PST ---
(In reply to comment #2)
> (From update of attachment 218149 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218149&action=review
> 
> > Source/WebKit/efl/ewk/ewk_contextmenu.h:112
> > +#if defined(ENABLE_INSPECTOR) && ENABLE_INSPECTOR
> 
> I think this isn't meaningful. ewk_contentmenu.h is public header. When application includes this, they can't know ENABLE_INSPECTOR is enabled or not.

This context menu item is correctly guarded in ContextMenuItem.h:134, but not here. These two must be in sync, as stated at the beginning of this file.

They are not in sync now, that causes a lot of enum assertions, therefore WebKit currenty doesn't build.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.