[Webkit-unassigned] [Bug 124209] [Cairo] Avoid extra copy when drawing images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124209


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com




--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-12-02 00:21:09 PST ---
(In reply to comment #3)
> (From update of attachment 216687 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=216687&action=review
> 
> > Source/WebCore/platform/graphics/cairo/PlatformContextCairo.cpp:181
> > +    if (srcRect.x() || srcRect.y()
> > +        || srcRect.width() != cairo_image_surface_get_width(surface)
> > +        || srcRect.height() != cairo_image_surface_get_height(surface)) {
> 
> There is no guarantee that this surface is an image surface. You could simplify this check to be:
> if (srcRect.x() || srcRect.y() || srcRect.size() == cairoSurfaceSize(surface))

Didn't you actually mean srcRect.x() || srcRect.y() || srcRect.size() != cairoSurfaceSize(surface)? The previous expression checked there's x or y or size is different.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.