[Webkit-unassigned] [Bug 124147] Report error when #else is used in message receiver generator's input.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 1 22:12:12 PST 2013


--- Comment #7 from Gergő Balogh <geryxyz at inf.u-szeged.hu>  2013-12-01 22:10:27 PST ---
(In reply to comment #6)
> (From update of attachment 217986 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217986&action=review
> This change is good, please feel free to review and land as appropriate.
> > Source/WebKit2/Scripts/webkit2/messages_unittest.py:1130
> > +        with self.assertRaisesRegexp(Exception, r"ERROR: '#else.*' are not supported in the \*\.in files"):
> Where does this ".*" come from? How is it helpful?

I use to follow the practise, that I give as much information as possible in an error message. Maybe it is irrelevant in the case of 'else', but I think if somebody make a mistake (for example 'else if' instead of 'elif') it will be nice to show the whole line, to help identify and correct it.

> > Source/WebKit2/Scripts/webkit2/parser.py:68
> > +                raise Exception("ERROR: '%s' are not supported in the *.in files" % trimmed)
> Shouldn't it be "... is not supported in .in files" (no "the", and singular)?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list