[Webkit-unassigned] [Bug 124147] Report error when #else is used in message receiver generator's input.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 1 13:51:45 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=124147





--- Comment #6 from Alexey Proskuryakov <ap at webkit.org>  2013-12-01 13:50:07 PST ---
(From update of attachment 217986)
View in context: https://bugs.webkit.org/attachment.cgi?id=217986&action=review

This change is good, please feel free to review and land as appropriate.

> Source/WebKit2/Scripts/webkit2/messages_unittest.py:1130
> +        with self.assertRaisesRegexp(Exception, r"ERROR: '#else.*' are not supported in the \*\.in files"):

Where does this ".*" come from? How is it helpful?

> Source/WebKit2/Scripts/webkit2/parser.py:68
> +                raise Exception("ERROR: '%s' are not supported in the *.in files" % trimmed)

Shouldn't it be "... is not supported in .in files" (no "the", and singular)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list