[Webkit-unassigned] [Bug 124945] [MIPS] Small stack frame causes regressions.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 1 06:13:59 PST 2013


Balazs Kilvady <kilvadyb at homejinni.com> changed:

           What    |Removed                     |Added
 Attachment #217960|0                           |1
        is obsolete|                            |
 Attachment #217960|review?, commit-queue?      |
               Flag|                            |
 Attachment #218110|                            |review?, commit-queue?
               Flag|                            |

--- Comment #4 from Balazs Kilvady <kilvadyb at homejinni.com>  2013-12-01 06:12:19 PST ---
Created an attachment (id=218110)
 --> (https://bugs.webkit.org/attachment.cgi?id=218110&action=review)
fixed patch.

I found that for 8 byte alignment reasons the 20 + x * 8 formula is reliable for extraStackSpace and in tests the lowest best value is 36 (It sees we have to add space for the four parameter registers on the stack also even if they aren't used). In mozilla tests there are still 13 regressions but they are caused by invalid register gp values. I think the fix of the gp problem should go to an other bug report/patch.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list