[Webkit-unassigned] [Bug 126317] New: webkitdirs.pm does not use environment variable VSINSTALLDIR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126317

           Summary: webkitdirs.pm does not use environment variable
                    VSINSTALLDIR
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows 7
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: david.delaune at hotmail.com
                CC: ap at webkit.org, ian at hixie.ch, jshin at chromium.org,
                    bfulgham at webkit.org, dimich at chromium.org,
                    jonlee at apple.com, roger_fong at apple.com,
                    mbaker at wyatt.com


Hi,

This change: https://bugs.webkit.org/show_bug.cgi?id=125998

Makes no sense whatsoever... it hard-codes the Visual Studio path using the environment variables %PROGRAMFILES(X86)% or %PROGRAMFILES% and yet ignores the environment variable %VSINSTALLDIR%.

This change incorrectly assumes that Visual Studio is always installed to (%PROGRAMFILES(X86)% or %PROGRAMFILES% or "C:\\Program Files").
Visual Studio may be installed on any drive... C through Z.
In my case... my OS is on drive C: and Visual Studio is installed on D: and this change completely breaks compiling.

What exactly was fixed here? Looks like a fix for 1 person?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.