[Webkit-unassigned] [Bug 126148] Support <box> values computed style for 'clip-path' property

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 25 14:59:22 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=126148





--- Comment #5 from Dirk Schulze <krit at webkit.org>  2013-12-25 14:57:19 PST ---
(In reply to comment #4)
> Attachment 220003 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/masking/parsing-clip-path-shape-expected.txt', u'LayoutTests/fast/masking/parsing-clip-path-shape.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/BasicShapeFunctions.cpp', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/rendering/ClipPathOperation.h', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/shapes/ShapeInfo.h', u'Source/WebCore/rendering/style/BasicShapes.cpp', u'Source/WebCore/rendering/style/BasicShapes.h', u'Source/WebCore/rendering/svg/SVGRenderingContext.cpp', '--commit-queue']" exit_code: 1
> ERROR: Source/WebCore/rendering/ClipPathOperation.h:158:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
> Total errors found: 1 in 14 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Ok, that is funny. One message wants me to do one thing, after that I shall revert the change :)

I'd land with the brace on its own line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list