[Webkit-unassigned] [Bug 126133] Make CachedSVGDocument independent of CSS Filters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126133


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219870|review?                     |review-
               Flag|                            |




--- Comment #5 from Antti Koivisto <koivisto at iki.fi>  2013-12-22 10:01:10 PST ---
(From update of attachment 219870)
View in context: https://bugs.webkit.org/attachment.cgi?id=219870&action=review

> Source/WebCore/loader/SVGDocumentConsumer.h:46
> +class SVGDocumentConsumer {
> +public:
> +    CachedSVGDocumentReference* cachedSVGDocumentReference() const { return m_cachedSVGDocumentReference.get(); }
> +    void setCachedSVGDocumentReference(PassOwnPtr<CachedSVGDocumentReference> cachedSVGDocumentReference) { m_cachedSVGDocumentReference = cachedSVGDocumentReference; }
> +
> +private:
> +    OwnPtr<CachedSVGDocumentReference> m_cachedSVGDocumentReference;
> +};    

This class is just a pointer. I don't see why we are introducing it and making code more abstract. Also name seem off. It doesn't 'consume' anything.

We use unique_ptr not OwnPtr.

> Source/WebCore/platform/graphics/filters/FilterOperation.h:160
> +class ReferenceFilterOperation : public FilterOperation, public SVGDocumentConsumer {

Why is ReferenceFilterOperation inheriting SVGDocumentConsumer instead of having one as a member?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.