[Webkit-unassigned] [Bug 126021] New: Different and possibly incorrect flags are passed to sendSync when accessibility is enabled, SpinRunLoopWhileWaitingForReply

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=126021

           Summary: Different and possibly incorrect flags are passed to
                    sendSync when accessibility is enabled,
                    SpinRunLoopWhileWaitingForReply
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ap at webkit.org
                CC: darin at apple.com, andersca at apple.com, sam at webkit.org,
                    cfleizach at apple.com,
                    webkit-bug-importer at group.apple.com


In WebKit2, we have multiple places where sendSync flags depend on whether accessibility is enabled.

    unsigned syncSendFlags = (WebCore::AXObjectCache::accessibilityEnabled()) ? CoreIPC::SpinRunLoopWhileWaitingForReply : 0;
    WebProcess::shared().parentProcessConnection()->sendSync(Messages::WebPageProxy::RunJavaScriptAlert(webFrame->frameID(), alertText), Messages::WebPageProxy::RunJavaScriptAlert::Reply(), m_page->pageID(), CoreIPC::Connection::NoTimeout, syncSendFlags);

It is unfortunate to have such differences, because we get to support two runtime behaviors instead of one. I think that we should either make SpinRunLoopWhileWaitingForReply unconditional, or stop passing SpinRunLoopWhileWaitingForReply, and find different fixes for bugs it was needed for.

Bug 126014 is one case where SpinRunLoopWhileWaitingForReply was found to cause significant trouble.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.