[Webkit-unassigned] [Bug 100275] Programmatically-inserted children lack accessibility events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100275





--- Comment #35 from Mario Sanchez Prada <mario at webkit.org>  2013-12-19 10:15:23 PST ---
(From update of attachment 219535)
View in context: https://bugs.webkit.org/attachment.cgi?id=219535&action=review

(In reply to comment #33)
> (From update of attachment 219535 [details])
> can you update the patch with the latest DetachmentType code I put in already

Sure

>> Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:85
>> +    AtkObject* atkParent = coreParent ? coreParent->wrapper() : 0;
> 
> you already checked for coreParent == nil above so you don't need to check again

Right

>> Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:199
>> +        if (int numOfChildren = atk_object_get_n_accessible_children(axObject)) {
> 
> i don't think you need this if statement. the for loop will take care of not doing any work for you

You are right. Actually I think I just did it to avoid declaring the numOfChildren variable outside the switch statement, or using an anonymous { } block just to bypass the limitation of switch statements, which do not allow declaring new variables in case sections :)

So, I would keep it anyway, if you don't mind

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.