[Webkit-unassigned] [Bug 124652] [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124652





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-12-19 06:22:42 PST ---
(In reply to comment #5)
> (From update of attachment 217417 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217417&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:142
> > + * webkit_response_policy_decision_is_mime_type_supported:
> 
> I like the name in principle. If we want to be very accurate about it, though, we could have webkit_response_policy_decision_can_web_view_show_mime_type(). I'm OK with is_mime_type_supported(), though, if you guys don't like that one ;) I agree with Carlos that can_show_mime_type makes a bit less sense here than in WebView.

I'm fine with is_mime_type_supported() too, Martin?

> > Source/WebKit2/UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:147
> > + * that triggered this policy decision request.
> > + * See also webkit_web_view_can_show_mime_type().
> 
> Nit: these could be on the same line.

Sure!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.