[Webkit-unassigned] [Bug 125941] Add Obj C API for injected bundle PageGroup class.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125941


mitz at webkit.org <mitz at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219566|review?                     |review+
               Flag|                            |




--- Comment #4 from mitz at webkit.org <mitz at webkit.org>  2013-12-18 14:49:02 PST ---
(From update of attachment 219566)
View in context: https://bugs.webkit.org/attachment.cgi?id=219566&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h:35
> +- (NSString *)identifier;

This is probably better expressed as @property (readonly) NSString *identifier;

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.mm:34
> +#import "WKAPICast.h"
> +#import "WKNSString.h"
> +#import "WKRetainPtr.h"

Probably don’t need these anymore.

> Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.h:47
> + at property(readonly) WKWebProcessPlugInFrame *mainFrame;
> +
> + at property(readonly) WKWebProcessPlugInPageGroup *pageGroup;

There needs to be a space before the (, even though some existing code is wrong.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.