[Webkit-unassigned] [Bug 125587] [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125587





--- Comment #5 from Mario Sanchez Prada <mario at webkit.org>  2013-12-16 03:01:37 PST ---
(From update of attachment 218983)
View in context: https://bugs.webkit.org/attachment.cgi?id=218983&action=review

>>>> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:651
>>>> +#if ATK_CHECK_VERSION(2, 11, 3)
>>> 
>>> Do you need this version check, since you updated the dependency already?
>> 
>> Yes, I need it because I updated the version of the package in the internal jhbuild system, but that is only used for development or testing (e.g. the buildbots). However, people will still be able to build WebKitGTK+ with former versions of ATK (from 2.8.0 on), which do not contain that role, so we need the check
> 
> So should you maintain an
> 
> #if
> #else
> #endif
> 
> scenario so that those older builders will get the old behavior?

That's what is already happening with this patch already now. Old builders will see:

    case DocumentArticleRole:
    case DocumentRole:
        return ATK_ROLE_DOCUMENT_FRAME;

Which is the same behaviour they saw before, just with the case staments swapped

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.