[Webkit-unassigned] [Bug 125600] Need ObjC APIs for some InjectedBundle classes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125600





--- Comment #7 from Yongjun Zhang <yongjun_zhang at apple.com>  2013-12-12 11:04:43 PST ---
(In reply to comment #5)
> (From update of attachment 219020 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=219020&action=review
> 
> >> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:41
> >> +- (JSGlobalContextRef)jsContextForWorld:(WKWebProcessPlugInScriptWorld *)world;
> > 
> > I believe that we should avoid the C JavaScript API types in our Cocoa API, so this method should return a (JSContext *).
> 
> Yeah, this should use the Objective-C JS API.
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h:42
> > +- (WKWebProcessPlugInHitTestResult *)hitTest:(CGPoint)point;
> 
> Can we put HitTest on the browsing controller instead?

Looks like hitTest is for a frame, not a page.  If we put in browsing controller, we will lose the ability to do hitTest on a subframe unless we change the API to something like:

[WKWebProcessPlugInBrowsingContextController hitTest:inFrame:].

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.