[Webkit-unassigned] [Bug 119618] Adding a .ycm_extra_conf file for webkitGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119618


Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com




--- Comment #3 from Adrian Perez <aperez at igalia.com>  2013-12-12 10:21:37 PST ---

I have just a couple of nits in this informal review. Apart from those, the
script is great and YCM is a really welcome addition to Vim (I did not know
about it before today :D)

> Tools/gtk/ycm_extra_conf.py:30
> +sys.path = [__tools_directory] + sys.path

It would be good to use os.path.abspath() after determining
__tools_directory, just in case.

> Tools/gtk/ycm_extra_conf.py:113
> +def FlagsForFile(filename):

According to the YouCompleteMe documentation, FlagsForFile may be passed
keyword arguments, so this should be:

  def FlagsForFile(filename, **kwargs)

Even if the keyword arguments are unused for the moment, it is good to
include them in the function signature just in case users have set an
option in their vimrc to send extra arguments to YCM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.