[Webkit-unassigned] [Bug 54928] PrettyPatch.rb doesn't handle diffs where lines matching /^--/ are missing properly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 12 08:04:18 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=54928





--- Comment #5 from Adam Roben (:aroben) <aroben at webkit.org>  2013-12-12 08:02:29 PST ---
(From update of attachment 219075)
View in context: https://bugs.webkit.org/attachment.cgi?id=219075&action=review

> Websites/bugs.webkit.org/PrettyPatch/PrettyPatch.rb:665
> +            line_array = string.each_line.to_a

I believe it's more idiomatic to use string.lines.to_a here instead of string.each_line.to_a

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list