[Webkit-unassigned] [Bug 125637] Broken error recovery in @media at-rule

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125637


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #219081|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #6 from Darin Adler <darin at apple.com>  2013-12-12 07:40:56 PST ---
(From update of attachment 219081)
View in context: https://bugs.webkit.org/attachment.cgi?id=219081&action=review

Fix looks fine. Test is incorrect, though. Easy to fix.

> LayoutTests/fast/css/media-error-recovery.html:6
> +	if (window.testRunner)
> +    	testRunner.dumpAsText();

This is a mistake. The test won’t work if you only dump the text. The test writes out the same text when it fails as when it succeeds. To make a text-only test, something in the test has to actually show whether the test has succeeded or failed.

For an example of one way to do this, please look at the media-rule-no-whitespace.html test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.