[Webkit-unassigned] [Bug 125467] PATH needs to include cygwin for WebKitVersion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125467


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #218801|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2013-12-11 15:06:44 PST ---
(From update of attachment 218801)
View in context: https://bugs.webkit.org/attachment.cgi?id=218801&action=review

r=me

> Source/WebKit/WebKit.vcxproj/WebKit/WebKitVersion.cmd:5
> +set PATH=%SystemDrive%\cygwin\bin;%PATH%

This assumes that Cygwin is always installed in "C:\cygwin", which may not be the case on all user's systems.

Still, it's a reasonable assumption for most people.

We might want to check "HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Cygwin\setup\rootdir" to get the true location.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.